Skip to content

Update some JS dependencies #13222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 21, 2020
Merged

Update some JS dependencies #13222

merged 4 commits into from
Oct 21, 2020
+878 −697

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Oct 20, 2020 •
edited
Loading

  • Update selective dependencies that are compatible with webpack 4. We can not upgrade to webpack 5 yet because license-webpack-plugin is incompatible.
  • Enable a few new eslint rules and fix new issues

@silverwind silverwind force-pushed the deps-18 branch 2 times, most recently from eb98061 to 831b11d Compare October 20, 2020 19:55
@silverwind
Update some JS dependencies

Verified

This commit was signed with the committer’s verified signature.
silverwind
GPG key ID: 2E62B41C93869443
Verified
Learn about vigilant mode
9e659fc 
- Update selective dependencies that are compatible with webpack 4. We
can not upgrade to webpack 5 yet because `license-webpack-plugin` is
incompatible.
- Enable a few new eslint rules and fix new issues
@techknowlogick techknowlogick added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Oct 20, 2020
@techknowlogick techknowlogick added this to the 1.14.0 milestone Oct 20, 2020
@techknowlogick
Copy link
Member

CI fail was weird, and really should be unrelated as this is JS change and CI reported golang fail. I've re-run CI and hopefully it'll pass this time.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 20, 2020
@silverwind
Copy link
Member Author

Seems like #13224 is the "fix".

@techknowlogick
Merge branch 'master' into deps-18

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
ea30dc7
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 21, 2020
@silverwind
fix comment

Verified

This commit was signed with the committer’s verified signature.
silverwind
GPG key ID: 2E62B41C93869443
Verified
Learn about vigilant mode
7799504
@codecov-io
Copy link

Codecov Report

Merging #13222 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13222      +/-   ##
==========================================
- Coverage   42.25%   42.21%   -0.05%     
==========================================
  Files         683      683              
  Lines       75381    75458      +77     
==========================================
- Hits        31854    31853       -1     
- Misses      38302    38381      +79     
+ Partials     5225     5224       -1
Impacted Files Coverage Δ
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
routers/repo/branch.go 56.35% <0.00%> (-1.98%) ⬇️
modules/log/file.go 73.60% <0.00%> (-1.61%) ⬇️
routers/repo/pull.go 31.77% <0.00%> (-1.53%) ⬇️
routers/repo/editor.go 23.80% <0.00%> (-1.49%) ⬇️
routers/repo/view.go 37.47% <0.00%> (-0.65%) ⬇️
routers/repo/repo.go 27.85% <0.00%> (ø)
modules/indexer/stats/db.go 60.86% <0.00%> (ø)
modules/git/repo.go 46.70% <0.00%> (+0.50%) ⬆️
modules/queue/workerpool.go 60.00% <0.00%> (+1.22%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48a8009...7799504. Read the comment docs.

@zeripath
Merge branch 'master' into deps-18

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
883cb6d
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 21, 2020
@lunny lunny merged commit 58e1e5b into go-gitea:master Oct 21, 2020
@silverwind silverwind deleted the deps-18 branch October 21, 2020 12:25
ivanvc added a commit to ivanvc/gitea that referenced this pull request Oct 21, 2020
@ivanvc
Merge remote-tracking branch 'origin/master' into update-outdated-com…

Verified

This commit was signed with the committer’s verified signature.
ivanvc Iván Valdés Castillo
GPG key ID: 4037D37741ED0CC5
Verified
Learn about vigilant mode
f5c3a69 
…ments-in-pull-request-label-style

* origin/master: (27 commits)
  [skip ci] Updated translations via Crowdin
  add more clarification to the issue-template.md (go-gitea#13235)
  go-version constraints ignore pre-releases (go-gitea#13234)
  [skip ci] Updated translations via Crowdin
  Update some JS dependencies (go-gitea#13222)
  Return the full rejection message and errors in flash errors (go-gitea#13221)
  Update heatmap fixtures to restore tests (go-gitea#13224)
  [skip ci] Updated translations via Crowdin
  Add review request api (go-gitea#11355)
  [skip ci] Updated translations via Crowdin
  When the git ref is unable to be found return broken pr (go-gitea#13218)
  Various arc-green fixes (go-gitea#13214)
  Show stale label for stale code comment which is marked as resolved (go-gitea#13213)
  Move install pages out of main macaron routes (go-gitea#13195)
  Use CSS Variables for fonts, remove postcss-loader (go-gitea#13204)
  [skip ci] Updated translations via Crowdin
  Align `SSH_AUTHORIZED_KEYS_BACKUP` var with the value in `app.ini` (go-gitea#13212)
  Fix size and clickable area on file table back link (go-gitea#13205)
  [skip ci] Updated translations via Crowdin
  Fix error in diff html rendering (go-gitea#13191)
  ...
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks

+1 more reviewer

@zeripath zeripath

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@silverwind @techknowlogick @codecov-io @lafriks @zeripath @lunny @GiteaBot